Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(defaults): set proper Accept-Encoding for server side #176

Merged
merged 4 commits into from Nov 7, 2018

Conversation

Projects
None yet
4 participants
@jericopulvera
Copy link
Contributor

jericopulvera commented Nov 5, 2018

Resolves #170

@jericopulvera jericopulvera reopened this Nov 5, 2018

@manniL manniL requested a review from pi0 Nov 5, 2018

@manniL

manniL approved these changes Nov 5, 2018

@dohomi

This comment has been minimized.

Copy link

dohomi commented Nov 7, 2018

I had the exact same issue. Would be great being merged

Show resolved Hide resolved lib/plugin.template.js Outdated
Update plugin.template.js
Don't set content-encoding if in browser
}

if (process.server) {
headers['Accept-Encoding'] = 'gzip, deflate'

This comment has been minimized.

@manniL

manniL Nov 7, 2018

Member

That should be in common I think 🤔

This comment has been minimized.

@jericopulvera

jericopulvera Nov 7, 2018

Author Contributor

@manniL @pi0 don't know why but It didn't work for me when it's in common.

tried it locally.

@pi0

pi0 approved these changes Nov 7, 2018

@pi0 pi0 changed the title This pr fixes brotli gibberish response on server. fix(defaults): set proper Accept-Encoding for server side Nov 7, 2018

@pi0 pi0 merged commit c84fb56 into nuxt-community:dev Nov 7, 2018

@jericopulvera

This comment has been minimized.

Copy link
Contributor Author

jericopulvera commented Nov 7, 2018

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.