Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): correct Vuex Store instance #227

Merged
merged 1 commit into from Mar 5, 2019

Conversation

Projects
None yet
2 participants
@RomainLanz
Copy link
Contributor

RomainLanz commented Mar 5, 2019

Hey 馃憢

When calling the inject method we add to the Vuex Store the $axios key.

Therefore, we need to add its typing.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 5, 2019

Codecov Report

Merging #227 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #227   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files         1      1           
  Lines        27     27           
  Branches     12     12           
===================================
  Hits         27     27

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update df6ce84...42df3ef. Read the comment docs.

@pi0

This comment has been minimized.

Copy link
Member

pi0 commented Mar 5, 2019

Thanks @RomainLanz 馃憤

@pi0 pi0 merged commit 1ed6e2f into nuxt-community:dev Mar 5, 2019

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing df6ce84...42df3ef
Details
codecov/project 100% remains the same compared to df6ce84
Details

pi0 added a commit that referenced this pull request Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.