Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use `server` of nuxt.config.js to set default baseURL #245

Merged
merged 1 commit into from May 22, 2019

Conversation

Projects
None yet
4 participants
@codecov

This comment has been minimized.

Copy link

commented May 3, 2019

Codecov Report

Merging #245 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #245   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files         1      1           
  Lines        27     27           
  Branches     12     12           
===================================
  Hits         27     27
Impacted Files Coverage Δ
lib/module.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f744666...9e6f7c7. Read the comment docs.

@Atinux Atinux requested review from Atinux, manniL and pi0 May 21, 2019

@Atinux

Atinux approved these changes May 21, 2019

Copy link
Member

left a comment

Sounds good to me, cc @pi0 & @manniL

@manniL

manniL approved these changes May 21, 2019

Copy link
Member

left a comment

LGTM 🤔

@pi0 pi0 merged commit e1120a9 into nuxt-community:dev May 22, 2019

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing f744666...9e6f7c7
Details
codecov/project 100% remains the same compared to f744666
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.