Skip to content

Conversation

@NickBolles
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Jun 27, 2019

Codecov Report

Merging #264 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #264   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files         1      1           
  Lines        28     28           
  Branches     13     13           
===================================
  Hits         28     28

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 953ab8c...0aeb7f6. Read the comment docs.

@pi0 pi0 requested a review from kevinmarrec June 27, 2019 06:32
Copy link
Member

@kevinmarrec kevinmarrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @NickBolles, thanks for the PR !

There's a cleaner way to tell TypeScript to load the types, it's through tsconfig.json with compilerOptions.types array property :

{
  "compilerOptions": {
    "types": [
      "@nuxt/vue-app",
      "@nuxtjs/axios"
    ]
  }
}

So the guidelines should be only about adding @nuxtjs/axios in the types array which should already contains @nuxt/vue-app to have core types working.

@NickBolles
Copy link
Contributor Author

@kevinmarrec huh. I tried that but it wasn't working for me. I was going to put that in the docs.

Any ideas why that wouldn't be working for me? I'll update the PR either way though.

@kevinmarrec
Copy link
Member

@NickBolles Is it still not working ? I can take a look if you have reproduction repo

@NickBolles
Copy link
Contributor Author

@kevinmarrec still not working on my laptop, but it's working on other computer. Something's probably just messed up with my laptop.

Updated the instructions. Thank you!

@pi0
Copy link
Member

pi0 commented Jul 4, 2019

Thanks @NickBolles @kevinmarrec ❤️

@pi0 pi0 changed the title docs: Add typescript type instructions docs: add typescript instructions Jul 4, 2019
@pi0 pi0 merged commit 8977bf9 into nuxt-community:dev Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants