Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow adding custom headers with nuxt config #294

merged 9 commits into from Oct 21, 2019

feat: allow adding custom headers with nuxt config #294

merged 9 commits into from Oct 21, 2019


Copy link

@ricardogobbosouza ricardogobbosouza commented Oct 11, 2019

Resolve #146

Copy link

@codecov codecov bot commented Oct 11, 2019

Codecov Report

Merging #294 into dev will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #294   +/-   ##
  Coverage   100%   100%           
  Files         1      1           
  Lines        28     30    +2     
  Branches     13     13           
+ Hits         28     30    +2
Impacted Files Coverage Δ
lib/module.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdb9837...bcb0b62. Read the comment docs.

Copy link

@pi0 pi0 left a comment

Thanks! Also please just make relavant changes to yarn.lock

docs/ Outdated Show resolved Hide resolved
lib/module.js Outdated Show resolved Hide resolved
lib/plugin.js Outdated Show resolved Hide resolved
@ricardogobbosouza ricardogobbosouza requested a review from pi0 Oct 12, 2019
pi0 approved these changes Oct 21, 2019
@pi0 pi0 changed the title feat: custom header on nuxt config feat: allow adding custom headers with nuxt config Oct 21, 2019
@pi0 pi0 merged commit 3e38906 into nuxt-community:dev Oct 21, 2019
3 checks passed
Copy link

@pi0 pi0 commented Oct 21, 2019

Thanks mate :)

Copy link

@A5rocks A5rocks commented May 28, 2022

Hello! Just writing this mainly as a spot for people to find from search. AFAICT you cannot remove headers from the default proxyHeadersIgnore due to this change -- defu concatenates arrays together. This means if you provide a list without a certain header which is in the default list... your change is futile.

A question for PR author / @pi0: was this change on purpose? The only way to remove CF-Connecting-IP from the list seems to be to use patch-package. Needless to say, I don't like this "fix".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

3 participants