Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin): don't convert falsy urls to string #347

Merged
merged 1 commit into from Mar 30, 2020
Merged

Conversation

pimlie
Copy link
Member

@pimlie pimlie commented Mar 30, 2020

This fixes the issue that

const o = {
        a: undefined
}

console.log(`${o.a}`)

will log 'undefined'

@pimlie pimlie requested a review from pi0 Mar 30, 2020
@pi0 pi0 changed the title fix: dont convert falsy urls to string fix(plugin): don't convert falsy urls to string Mar 30, 2020
@pi0 pi0 merged commit b8a510e into dev Mar 30, 2020
4 checks passed
@pi0
Copy link
Member

pi0 commented Mar 30, 2020

Thanks @pimlie for the fix. Would be appreciated if you can add same fix PR for http module :) Also a note on use case.

@pi0 pi0 deleted the fix-undefined-to-string branch Mar 30, 2020
@pi0
Copy link
Member

pi0 commented Mar 30, 2020

published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants