fix(plugin): add missing $ prefix to globalName

[ricosmall]

Problem:

The globalName equals nuxt if we didn't set it in nuxt.config.js, when you use window[globalName] which means window['nuxt'] to get global $nuxt, will return undefined, you need use window['$nuxt'] to get it.

Solution:

To get global $nuxt, you need use

window[`$${globalName}`]

So we can define the variable globalName with a $ prefix to make it right.

See source code below to get more info:

https://github.com/nuxt/nuxt.js/blob/85383688371f5ba7b079e1d829a1ada91bc11eaf/packages/config/src/config/_common.js#L16-L23

[codecov]

Codecov Report

Merging #356 into dev will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               dev      #356   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           30        30           
  Branches        12        12           
=========================================
  Hits            30        30           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b46693b...8c677c2. Read the comment docs.

[pi0]

Thanks @ricosmall

[sami-baadarani]

Getting error "globalName is not defined" in nuxt version 1.4.5
@pi0 @ricosmall

[ricosmall]

@sami-baadarani what is the @nuxtjs/axios version you used?

[sami-baadarani]

@ricosmall We are forced to use version 5.9.7.
The issues with globalName started from version 5.10.0

[pi0]

@sami-baadarani Should be fixed by 5.10.3

[sami-baadarani]

Thanks @ricosmall @pi0 :)