Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin): always get global $nuxt while loading #364

Merged
merged 1 commit into from May 26, 2020

Conversation

erraX
Copy link
Contributor

@erraX erraX commented May 15, 2020

window.$nuxt is undefined when importing plugin.js
so $loading is always noopLoading, progress bar never appear.

@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #364 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev      #364   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           31        31           
  Branches        13        13           
=========================================
  Hits            31        31           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0957082...16a9215. Read the comment docs.

@ricardogobbosouza ricardogobbosouza self-requested a review May 20, 2020
@ricardogobbosouza ricardogobbosouza requested a review from pi0 May 20, 2020
pi0
pi0 approved these changes May 26, 2020
Copy link
Member

@pi0 pi0 left a comment

Thanks!

@pi0 pi0 merged commit e848b9d into nuxt-community:dev May 26, 2020
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants