Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin): support runtimeConfig #387

merged 8 commits into from Jul 9, 2020


Copy link

@SkyaTura SkyaTura commented Jul 7, 2020

This PR adds ctx.$config.axios to the plugin, which solves #386

Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #387 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev      #387   +/-   ##
  Coverage   100.00%   100.00%           
  Files            1         1           
  Lines           32        32           
  Branches        13        13           
  Hits            32        32           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc50e46...c2bc6d6. Read the comment docs.

lib/plugin.js Outdated Show resolved Hide resolved
Copy link

@pi0 pi0 left a comment

Thanks! I was lazy to finish this feature

@pi0 pi0 changed the title fix(plugin): use runtimeConfig before options feat(plugin): support runtimeConfig Jul 7, 2020
Copy link

pi0 commented Jul 7, 2020

@SkyaTura Do you mind also updating the docs?

Copy link
Contributor Author

SkyaTura commented Jul 8, 2020

Done @pi0

@SkyaTura SkyaTura requested a review from pi0 Jul 8, 2020
docs/ Outdated Show resolved Hide resolved
docs/ Show resolved Hide resolved
docs/ Outdated Show resolved Hide resolved
docs/ Outdated Show resolved Hide resolved
docs/ Outdated Show resolved Hide resolved
docs/ Outdated
- `browserBaseURL`

Copy link

@pi0 pi0 Jul 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For syntax highlighting, it should be ```js

pi0 approved these changes Jul 9, 2020
@pi0 pi0 merged commit 351ea5e into nuxt-community:dev Jul 9, 2020
1 of 2 checks passed
Copy link

pi0 commented Jul 9, 2020

Thanks @SkyaTura ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants