Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin): hide progress bar on cancelled requests #398

Merged
merged 5 commits into from Aug 3, 2020
Merged

fix(plugin): hide progress bar on cancelled requests #398

merged 5 commits into from Aug 3, 2020

Conversation

T0shik
Copy link
Contributor

@T0shik T0shik commented Aug 1, 2020

At the moment if there is a long running request that should be cancelled (like a video upload or something) the loading bar stays.

This pr is for decrementing the request cound and hiding the progress bar if last request.

@codecov
Copy link

codecov bot commented Aug 1, 2020

Codecov Report

Merging #398 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               dev      #398   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           32        32           
  Branches        13        13           
=========================================
  Hits            32        32           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 669d969...bee9f01. Read the comment docs.

test/fixture/api.js Show resolved Hide resolved
@pi0 pi0 changed the title Hide progress bar on cancelled requests fix(plugin): hide progress bar on cancelled requests Aug 3, 2020
@pi0 pi0 merged commit 2061721 into nuxt-community:dev Aug 3, 2020
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants