Correctly register idTokenChanged callback #508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Hey @BboyKeen Please excuse the late response, buys times. Thanks a lot for you contribution, that makes sense! Appreciate your contribution! Best regards |
Author
|
You're welcome :) |
Member
|
Published with v7.6.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
It looks like the callback for idTokenChanged was naively introduced in the module in this commit fcf0846#diff-3d37c994b7571c62b0cfb339a4994a7ee10e263b6c6216a3d7b0b19516f52b1d
If both authStateChanged and idTokenChanged callbacks are used, the first return prevents the second callback to be registered so the Firebase update is never propagated.
With this PR, this problem should be fixed. Feel free to ask me to update it if necessarily.