fix(pwa-utils): ensure joinUrl not modifying scheme part

pooya parsa · pooya parsa · commit 09a465ac888c · 2019-02-08T00:29:34.000+03:30
diff --git a/packages/pwa-utils/index.js b/packages/pwa-utils/index.js
@@ -9,7 +9,7 @@ function isUrl (url) {
 }
 
 function joinUrl (...args) {
-  return path.join(...args)
+  return path.join(...args).replace(':/', '://')
 }
 
 function getRouteParams (options) {
diff --git a/test/fixture/nuxt.config.js b/test/fixture/nuxt.config.js
@@ -20,6 +20,10 @@ module.exports = {
     description: 'Test Project Description'
   },
 
+  // build: {
+  //   publicPath: 'https://cdn.com/assets/'
+  // },
+
   workbox: {
     offlineAnalytics: true,
     dev: true,

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ function isUrl (url) {`
`9`	`9`	`}`
`10`	`10`
`11`	`11`	`function joinUrl (...args) {`
`12`		`- return path.join(...args)`
	`12`	`+ return path.join(...args).replace(':/', '://')`
`13`	`13`	`}`
`14`	`14`
`15`	`15`	`function getRouteParams (options) {`