fix(workbox): use NetworkFirst for dev

pooya parsa · pooya parsa · commit 9a67580badc5 · 2019-05-06T18:55:51.000+04:30
diff --git a/packages/workbox/lib/options.js b/packages/workbox/lib/options.js
@@ -42,10 +42,10 @@ function getOptions (moduleOptions) {
   if (!options.assetsURLPattern) {
     options.assetsURLPattern = joinUrl(options.publicPath, HMRRegex)
   }
-  if (options.cacheAssets && !this.options.dev) {
+  if (options.cacheAssets) {
     options.runtimeCaching.push({
       urlPattern: options.assetsURLPattern,
-      handler: 'CacheFirst'
+      handler: this.options.dev ? 'NetworkFirst' : 'CacheFirst'
     })
   }
 

Original file line number	Diff line number	Diff line change
`@@ -42,10 +42,10 @@ function getOptions (moduleOptions) {`
`42`	`42`	`if (!options.assetsURLPattern) {`
`43`	`43`	`options.assetsURLPattern = joinUrl(options.publicPath, HMRRegex)`
`44`	`44`	`}`
`45`		`- if (options.cacheAssets && !this.options.dev) {`
	`45`	`+ if (options.cacheAssets) {`
`46`	`46`	`options.runtimeCaching.push({`
`47`	`47`	`urlPattern: options.assetsURLPattern,`
`48`		`- handler: 'CacheFirst'`
	`48`	`+ handler: this.options.dev ? 'NetworkFirst' : 'CacheFirst'`
`49`	`49`	`})`
`50`	`50`	`}`
`51`	`51`