fix(workbox): disable cacheAssets for dev mode

pooya parsa · pooya parsa · commit dbf6d67bea83 · 2019-05-06T18:12:33.000+04:30
diff --git a/packages/workbox/lib/options.js b/packages/workbox/lib/options.js
@@ -42,7 +42,7 @@ function getOptions (moduleOptions) {
   if (!options.assetsURLPattern) {
     options.assetsURLPattern = joinUrl(options.publicPath, HMRRegex)
   }
-  if (options.cacheAssets) {
+  if (options.cacheAssets && !this.options.dev) {
     options.runtimeCaching.push({
       urlPattern: options.assetsURLPattern,
       handler: 'CacheFirst'

Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ function getOptions (moduleOptions) {`
`42`	`42`	`if (!options.assetsURLPattern) {`
`43`	`43`	`options.assetsURLPattern = joinUrl(options.publicPath, HMRRegex)`
`44`	`44`	`}`
`45`		`- if (options.cacheAssets) {`
	`45`	`+ if (options.cacheAssets && !this.options.dev) {`
`46`	`46`	`options.runtimeCaching.push({`
`47`	`47`	`urlPattern: options.assetsURLPattern,`
`48`	`48`	`handler: 'CacheFirst'`