Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cache names to be configured #154

Merged
merged 5 commits into from Mar 2, 2019

Conversation

jezhodges
Copy link
Contributor

@jezhodges jezhodges commented Feb 28, 2019

This is a proposal to add the ability to configure the workbox cache names.

See https://developers.google.com/web/tools/workbox/guides/configure-workbox#configure_cache_names for more information on this.

@codecov
Copy link

codecov bot commented Feb 28, 2019

Codecov Report

Merging #154 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev   #154   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files         1      1           
  Lines         2      2           
===================================
  Hits          2      2
Impacted Files Coverage Δ
test/fixture/nuxt.config.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45ac27d...6d20944. Read the comment docs.

@manniL manniL requested a review from pi0 Feb 28, 2019
Copy link
Member

@pi0 pi0 left a comment

Thanks for the PR and nice discover! 😊

test/fixture/nuxt.config.js Show resolved Hide resolved
pi0
pi0 approved these changes Mar 2, 2019
@pi0 pi0 merged commit 2d7ed53 into nuxt-community:dev Mar 2, 2019
1 check passed
@jezhodges
Copy link
Contributor Author

jezhodges commented Mar 4, 2019

@pi0 any chance of a release to incorporate these changes please?

@pi0
Copy link
Member

pi0 commented Mar 4, 2019

@jezhodges expect it in a few hours. I've to finish some initial works on workbox-window.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants