New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow overidding of publicPath for manifest module #19

Merged
merged 1 commit into from Dec 6, 2017

Conversation

Projects
None yet
2 participants
@simllll
Contributor

simllll commented Dec 6, 2017

for CDN use it is important that the manifest is serverd frome the same domain, and not from the CDN.
Even though it is actually allowed to server the manifest from a different domain, you will run into other troubles like start_url is cross-origin and so on that this approach is the easiest one to fix it. (see issue #18)

after this PR it's possible to overwrite the publicPath for manifest module (like it is already possible in workbox module). my nuxt.config.js looks therefore like this (I overwrite the publicPath explicity by my _nuxt path without the cdn)

modules: [
      ['@nuxtjs/pwa', {workbox: {publicPath: '/_nuxt/'}, manifest: {publicPath: "/_nuxt/"}}],
  ],

regards
Simon

@simllll simllll changed the title from allow overidding of publicPath to allow overidding of publicPath for manifest module Dec 6, 2017

@pi0

This comment has been minimized.

Member

pi0 commented Dec 6, 2017

awesome thanks!

@pi0 pi0 merged commit 4e6782e into nuxt-community:master Dec 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment