Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add types #323

Closed
wants to merge 4 commits into from
Closed

Conversation

jefrydco
Copy link
Contributor

@jefrydco jefrydco commented Aug 15, 2020

No description provided.

@codecov
Copy link

codecov bot commented Aug 15, 2020

Codecov Report

Merging #323 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #323   +/-   ##
=======================================
  Coverage   85.43%   85.43%           
=======================================
  Files          10       10           
  Lines         357      357           
  Branches      108      108           
=======================================
  Hits          305      305           
  Misses         48       48           
  Partials        4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65800f9...64409a4. Read the comment docs.

@pi0 pi0 changed the title Add Typescript Declaration feat: add types Aug 16, 2020
pi0 pushed a commit that referenced this issue Aug 16, 2020
Co-Authored-By: pooya parsa <pyapar@gmail.com>

 #   feat(types): add boolean options for pwa options interface

 #   feat(types): add typescript declaration

 #   chore: add types field and include types dir on publish

 #   chore: add nuxt types and workbox sw types
@pi0
Copy link
Member

pi0 commented Aug 16, 2020

Thanks for the PR @jefrydco perfect time ❤️ I've merged PR with some changes by 8723d07 (couldn't push on this branch)

@pi0 pi0 closed this Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants