Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icon): update warning url to docs #329

Merged
merged 1 commit into from Aug 17, 2020
Merged

fix(icon): update warning url to docs #329

merged 1 commit into from Aug 17, 2020

Conversation

ludo237
Copy link
Contributor

@ludo237 ludo237 commented Aug 17, 2020

I stumbled upon this console warning today but the URL was wrong and it pointed to a 404 page of the doc. This should be the right URL to use.

I stumbled upon this console warning today but the URL was wrong and it pointed to a 404 page of the doc. This should be the right URL to use.
@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #329 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #329   +/-   ##
=======================================
  Coverage   85.43%   85.43%           
=======================================
  Files          10       10           
  Lines         357      357           
  Branches      108      108           
=======================================
  Hits          305      305           
  Misses         48       48           
  Partials        4        4           
Impacted Files Coverage Δ
lib/meta/module.js 81.90% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc2a12a...c1de399. Read the comment docs.

pi0
pi0 approved these changes Aug 17, 2020
@pi0
Copy link
Member

pi0 commented Aug 17, 2020

Thanks @ludo237

@pi0 pi0 changed the title Fix wrong URL used on console.warn fix(icon): update warning url to docs Aug 17, 2020
@pi0 pi0 merged commit 61633fa into nuxt-community:master Aug 17, 2020
7 of 8 checks passed
@ludo237 ludo237 deleted the patch-1 branch Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants