Skip to content

fix(icon): fork without original process args #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

1ed
Copy link
Contributor

@1ed 1ed commented Sep 8, 2020

When we start the server e.g. with --inspect and forking it
with the default process.execArgv it will cause an error,
because it wants to start the inspector again on the same port.

This patch fixes this issue.

Related to #218

When we start the server e.g. with --inspect and forking it
with the default process.execArgv it will cause an error,
because it wants to start the inspector again on the same port.

This patch fixes this issue.
@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #343 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #343   +/-   ##
=======================================
  Coverage   85.43%   85.43%           
=======================================
  Files          10       10           
  Lines         357      357           
  Branches      108      108           
=======================================
  Hits          305      305           
  Misses         48       48           
  Partials        4        4           
Impacted Files Coverage Δ
lib/icon/module.js 93.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c59a9dc...2900f66. Read the comment docs.

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 💯

@pi0 pi0 merged commit 8b1f19f into nuxt-community:master Sep 8, 2020
@1ed 1ed deleted the fork-without-args branch September 9, 2020 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants