New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icon): make icons accessible #51

Merged
merged 4 commits into from Sep 1, 2018

Conversation

Projects
None yet
3 participants
@manniL
Member

manniL commented Mar 22, 2018

With this PR, icons can be accessed through Vue.$icons (or custom property name).

Use case:
Sometimes you want to use smaller versions of your original logo on your page. Instead of adding another image to assets, you can now get URL and size directly through Vue.

Resolves #46

@manniL manniL force-pushed the manniL:feature-accessible-icons branch from 0b70cbf to c1cf1b7 Mar 22, 2018

@manniL

This comment has been minimized.

Member

manniL commented Apr 25, 2018

Ping @pi0

@pi0

This comment has been minimized.

Member

pi0 commented Aug 24, 2018

Hey @manniL. Sorry for missing this PR. Actually, this would be a nice feature but it's somehow out of the PWA/icon's scope. I mean we can make this plugin to inject $icon with a more convenient Interface like <img :src="$icon('default', 256)> (and in future abilities like adding more icon assets)

@manniL

This comment has been minimized.

Member

manniL commented Aug 24, 2018

@pi0 No problem at all! ☺️

Will update the PR with your suggestion as soon as I can!

@pi0 pi0 changed the base branch from master to develop Aug 24, 2018

@pi0 pi0 changed the title from Make icons accessible to feat(icon): make icons accessible Aug 24, 2018

@pi0 pi0 added the WIP label Aug 24, 2018

@manniL manniL force-pushed the manniL:feature-accessible-icons branch from c1cf1b7 to c6c226e Sep 1, 2018

@manniL

This comment has been minimized.

Member

manniL commented Sep 1, 2018

@pi0 Updated!

@manniL manniL removed the WIP label Sep 1, 2018

@manniL manniL requested review from pi0 and galvez Sep 1, 2018

@galvez

This comment has been minimized.

Collaborator

galvez commented Sep 1, 2018

LGTM @manniL are tests passing on your side?

@manniL

This comment has been minimized.

Member

manniL commented Sep 1, 2018

@galvez Yup. Removed a forgotten console.log, now everything should be fine ☺️

@galvez galvez merged commit 92bccd3 into nuxt-community:develop Sep 1, 2018

@manniL manniL deleted the manniL:feature-accessible-icons branch Sep 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment