New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new attribute to link tag for manifest.json #71

Merged
merged 1 commit into from Aug 24, 2018

Conversation

Projects
None yet
4 participants
@gyarasu
Contributor

gyarasu commented Jul 6, 2018

In the case of Basic Authentication, manifest.json isn't downloaded properly.
To solve this problem, I added the crossorigin attribute for link tag.
We can set the attribute as below.

modules: [
  ['@nuxtjs/pwa', {manifest: {crossorigin: "use-credentials"}}],
],

As a result, link tag is generated as below.

<link data-n-head="true" rel="manifest" href="/_nuxt/manifest.json" crossorigin="use-credentials"/>

regards
Hiroki

@manniL

manniL approved these changes Jul 22, 2018

@XanderLuciano

Tested and verified as functional.
Backwards compatible with current manifest file as well.

Have not run into any issues.

@pi0

pi0 approved these changes Aug 24, 2018

@pi0 pi0 merged commit ccb2c33 into nuxt-community:master Aug 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment