New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

offlinePageAssets -> offlineAssets, provided regardlessly #86

Merged
merged 5 commits into from Aug 28, 2018

Conversation

Projects
None yet
2 participants
@galvez
Collaborator

galvez commented Aug 25, 2018

Change to make sure users are able to easily provide a list of extra files to precache rather than having to use cachingExtensions -- which is meant for complex use-cases. So I've removed offlinePageAssets (which only worked when offlinePage was also defined) and provided the new global offlineAsset option instead :)

@galvez galvez requested a review from pi0 Aug 25, 2018

@codecov

This comment has been minimized.

codecov bot commented Aug 25, 2018

Codecov Report

Merging #86 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           develop    #86   +/-   ##
======================================
  Coverage      100%   100%           
======================================
  Files            1      1           
  Lines            2      2           
======================================
  Hits             2      2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a8bb3b...4128807. Read the comment docs.

pi0 added some commits Aug 28, 2018

@galvez

This comment has been minimized.

Collaborator

galvez commented on d0c9150 Aug 28, 2018

@pi0 good call!

@pi0 pi0 merged commit 27c8fa1 into develop Aug 28, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 7a8bb3b...4128807
Details
codecov/project 100% remains the same compared to 7a8bb3b
Details

@pi0 pi0 deleted the offline-assets-enhancement branch Aug 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment