New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workbox): support pass config object to `workbox.setConfig` #95

Merged
merged 1 commit into from Sep 21, 2018

Conversation

Projects
None yet
3 participants
@CarterLi
Contributor

CarterLi commented Sep 19, 2018

Currently there is no way to use local workbox files, it's rather important if you can't access google CDN ( for example in China ). I'm adding a new option config to support this.

It also enables other features such as forcing enabling debug mode.

@CarterLi CarterLi force-pushed the CarterLi:develop branch from 3ed5c11 to b4991fc Sep 19, 2018

@CarterLi CarterLi force-pushed the CarterLi:develop branch from b4991fc to bf935ba Sep 19, 2018

@CarterLi CarterLi changed the title from feat(workbox): support pass config object to `workbox.config` to feat(workbox): support pass config object to `workbox.setConfig` Sep 19, 2018

@galvez

galvez approved these changes Sep 19, 2018

LGTM

@galvez galvez requested a review from pi0 Sep 19, 2018

@pi0

pi0 approved these changes Sep 21, 2018

@pi0 pi0 merged commit b5dab8a into nuxt-community:develop Sep 21, 2018

@CarterLi

This comment has been minimized.

Contributor

CarterLi commented Sep 21, 2018

What about a new release?

@pi0

This comment has been minimized.

Member

pi0 commented Sep 21, 2018

@CarterLi Released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment