Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An option for trailing slash would improve SEO #34

Closed
egidioFrat opened this issue Oct 17, 2018 — with CMTY · 4 comments

Comments

Projects
None yet
4 participants
Copy link

commented Oct 17, 2018 — with CMTY

What problem does this feature solve?

Missing trailing slash on URL of a directory force github pages to redirect HTTPS to HTTP.
isaacs/github#289

What does the proposed changes look like?

It could be an option to add trailing slash to static URL in sitemap.xml

This feature request is available on Nuxt community (#c32)

@cmty cmty bot added the cmty:feature-request label Oct 17, 2018

@hareku

This comment has been minimized.

Copy link

commented Oct 31, 2018

Yes. I need to append trailing slash too.

@derevandal

This comment has been minimized.

Copy link
Contributor

commented Jan 2, 2019

@egidioFrat @hareku
I use filter feature:

filter ({ routes }) {
  return routes.map(route => route.url = `${route.url}/`)
}
@NicoPennec

This comment has been minimized.

Copy link
Member

commented Jan 8, 2019

@derevandal
correct! since sitemap-module v0.2, use a custom filter is the simple way to fix the issue.

@egidioFrat @hareku
if necessary, we can add a new option to the module in order to auto add a trailing slash on each route. Do you think is useful ? or add your custom filter is enough ?

@NicoPennec NicoPennec self-assigned this Jan 8, 2019

@egidioFrat

This comment has been minimized.

Copy link
Author

commented Jan 8, 2019

I guess this filter solution is enough. Thank you @derevandal and @NicoPennec

@NicoPennec NicoPennec closed this Jan 9, 2019

@bdrtsky bdrtsky referenced this issue Apr 8, 2019

Closed

... #53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.