Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force https urls #84

Closed
starikovm opened this issue Oct 8, 2019 — with CMTY · 4 comments

Comments

Copy link

@starikovm starikovm commented Oct 8, 2019 — with CMTY

What problem does this feature solve?

I have a website running on https on heroku, so https request via CNAME goes to herou and website is hosted there.
What am I experiencing now is that isHTTPS(req) function on production is returning false for these kind of requests, probably because of current hosting architecture.

I wanted to raise a PR with an option for forced https links in sitemap to avoid such issues and such situations.

What does the proposed changes look like?

Option in sitemaps module like forceHTTPS, which then creates all links with https reagrdless of request type and so on.

This feature request is available on Nuxt community (#c69)
@cmty cmty bot added the cmty:feature-request label Oct 8, 2019

This comment has been minimized.

Copy link
Member

@NicoPennec NicoPennec commented Oct 8, 2019 — with CMTY

Your issue seems duplicate from that one: #56

2 solutions:

  • set an hostname value in your nuxt.config.js
sitemap: {
    hostname: 'https://example.com',
    // ...
}

This comment has been minimized.

Copy link
Author

@starikovm starikovm commented Oct 11, 2019 — with CMTY

@NicoPennec hostname is not an option, cause I have multi-domain website for different languages.
I ll investigate is-https package, thanks!

@ricardogobbosouza

This comment has been minimized.

Copy link
Member

@ricardogobbosouza ricardogobbosouza commented Oct 17, 2019

@NicoPennec can closed?

@NicoPennec

This comment has been minimized.

Copy link
Member

@NicoPennec NicoPennec commented Oct 17, 2019

yes, the x-forwarded-proto header is the right way if the hostname can not be set.

@NicoPennec NicoPennec closed this Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.