Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: closes #69 and & adds sitemap: false option to pages #70

Open
wants to merge 2 commits into
base: dev
from

Conversation

Projects
None yet
3 participants
@SnirShechter
Copy link

commented Jun 16, 2019

Closes #69 - adds data to routes in the filter function.

Also closes #c55 (for some reason the issue was not posted in github).

@codecov

This comment has been minimized.

Copy link

commented Jun 16, 2019

Codecov Report

Merging #70 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev    #70   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files         1      1           
  Lines         3      3           
===================================
  Hits          3      3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7a3bca...a6d2f83. Read the comment docs.

@SnirShechter

This comment has been minimized.

Copy link
Author

commented Jun 19, 2019

@NicoPennec
Can you take a look, please?

@codecov-io

This comment has been minimized.

Copy link

commented Jun 20, 2019

Codecov Report

Merging #70 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev    #70   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files         1      1           
  Lines         3      3           
===================================
  Hits          3      3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7a3bca...a6d2f83. Read the comment docs.

1 similar comment
@codecov-io

This comment has been minimized.

Copy link

commented Jun 20, 2019

Codecov Report

Merging #70 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev    #70   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files         1      1           
  Lines         3      3           
===================================
  Hits          3      3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7a3bca...a6d2f83. Read the comment docs.

@SnirShechter SnirShechter changed the title feat: closes #69 - adds data to routes in the filter function feat: closes #69 and #70 Jun 20, 2019

@SnirShechter SnirShechter changed the title feat: closes #69 and #70 feat: closes #69 and & adds sitemap: false option to pages Jun 20, 2019

@oriati

This comment has been minimized.

Copy link

commented Jun 20, 2019

this looks great!

@SnirShechter

This comment has been minimized.

Copy link
Author

commented Jun 26, 2019

@pi0 @NicoPennec
Guys, is this module even maintained?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.