Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated trailing slash filter code example #71

Merged
merged 1 commit into from Aug 1, 2019

Conversation

@miteyema
Copy link
Contributor

commented Jun 18, 2019

The code example in the documentation to add a trailing slash to each route by using a filter, throws away all data except for the URL itself.
If you have set defaults (e.g. lastmod), these are thrown away because of the way the function in the code example is written.
This PR fixes that issue, that is both trailing slashes (by using a filter) and defaults can be used when following the documentation.

@codecov

This comment has been minimized.

Copy link

commented Jun 18, 2019

Codecov Report

Merging #71 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@         Coverage Diff         @@
##            dev    #71   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files         1      1           
  Lines         3      3           
===================================
  Hits          3      3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7a3bca...fd84f00. Read the comment docs.

@NicoPennec

This comment has been minimized.

Copy link
Member

commented Aug 1, 2019

thanks for your PR 👍

@NicoPennec NicoPennec merged commit 7a3295f into nuxt-community:dev Aug 1, 2019

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing a7a3bca...fd84f00
Details
codecov/project 100% remains the same compared to a7a3bca
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.