fix: add hyphen to data attribute regexp #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for html-validator canceled.
|
danielroe
approved these changes
Oct 15, 2022
danielroe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Data attributes with multiple hyphens do not get removed entirely which causes the validator to check incorrect HTML.
Example
HTML (note the "-s"):
<p data-v-f17e0b0c-s>Test</p>HTML expected to run through validator:
<p>Test</p>HTML that actually runs through validator:
<p-s>Test</p>html-validator output:
Minimal reproduction
https://stackblitz.com/edit/github-cpclz6?file=components/test-outer.vue
Pull request suggested fix
I've added a hyphen character inside the matching list so that it will replace data attributes with multiple hyphens.