Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve config paths fully and warn on config errors #522

Merged
merged 2 commits into from Sep 8, 2022
Merged

fix: resolve config paths fully and warn on config errors #522

merged 2 commits into from Sep 8, 2022

Conversation

harlan-zw
Copy link
Contributor

@harlan-zw harlan-zw commented Aug 24, 2022 •
edited by Atinux

Resolves #515

This PR fixes a regression that broke the default config path loading.

Additionally:

  • it adds a warning message to users when a config module is loaded but fails
  • supports loading .mjs configs
  • properly types configPath (already is supported as an array)

@harlan-zw harlan-zw mentioned this pull request Aug 24, 2022
Closed
@fredagsfys
Copy link

Seems good to go, any reason not to merge and release the fix?

@harlan-zw
Copy link
Contributor Author

Waiting for a review by someone who can merge

@Atinux Atinux merged commit 6a6dc4f into nuxt-modules:main Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tailwind.config.js completely ignored
3 participants
@harlan-zw @fredagsfys @Atinux