fix: prevent duplicate manifest generation#1070
Merged
Conversation
Collaborator
Author
|
This PR seems likely to solve the strange issue as well. Using |
Collaborator
Author
|
@danielroe |
danielroe
approved these changes
Feb 5, 2024
danielroe
reviewed
Feb 5, 2024
| const clientManifestJSON = JSON.stringify(clientManifest, null, 2) | ||
| await fse.writeFile(resolve(buildDir, 'dist/server/client.manifest.json'), clientManifestJSON, 'utf-8') | ||
| await fse.writeFile(resolve(buildDir, 'dist/server/client.manifest.mjs'), `export default ${clientManifestJSON}`, 'utf-8') | ||
| await fse.writeFile(resolve(buildDir, 'dist/server/client.manifest.json'), clientManifestJSON, 'utf8') |
Member
There was a problem hiding this comment.
I don't believe this change is needed.
Collaborator
Author
|
Thank you ❤️ |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
❓ Type of change
📚 Description
I want to avoid duplicate generation of client.manifest.
In the case of a webpack production build, the manifest is generated in the following two places:
bridge/packages/bridge/src/module.ts
Lines 128 to 130 in cffcd07
bridge/packages/bridge/src/nitro.ts
Lines 241 to 251 in cffcd07
📝 Checklist