From 2232fbf729c20e8fe208f2162b7edb0c7fdaf4b3 Mon Sep 17 00:00:00 2001 From: gxres042 Date: Sun, 25 Aug 2024 20:03:52 +0800 Subject: [PATCH 1/2] feat(module): install the dependency in specific list as devDependencies --- src/commands/module/add.ts | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/commands/module/add.ts b/src/commands/module/add.ts index e07b5318b..8d2634ecf 100644 --- a/src/commands/module/add.ts +++ b/src/commands/module/add.ts @@ -15,6 +15,12 @@ import { } from './_utils' import type { NuxtModule } from './_utils' +// Maybe we can import the list from somewhere, but idk +const forceDevDependencies = [ + "@nuxt/eslint@latest", + "@nuxtjs/color-mode" +] + export default defineCommand({ meta: { name: 'add', @@ -60,7 +66,7 @@ export default defineCommand({ // Add npm dependency if (!ctx.args.skipInstall) { - const isDev = Boolean(projectPkg.devDependencies?.nuxt) + const isDev = Boolean(projectPkg.devDependencies?.nuxt || forceDevDependencies.includes(r.pkg)) consola.info( `Installing \`${r.pkg}\`${isDev ? ' development' : ''} dependency`, ) From abfec02cc28b839c95d7a86474bcce35f3ac3961 Mon Sep 17 00:00:00 2001 From: gxres042 Date: Sun, 25 Aug 2024 20:11:22 +0800 Subject: [PATCH 2/2] fix: detect dependency name without '@latest' --- src/commands/module/add.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/commands/module/add.ts b/src/commands/module/add.ts index 8d2634ecf..356359731 100644 --- a/src/commands/module/add.ts +++ b/src/commands/module/add.ts @@ -17,7 +17,7 @@ import type { NuxtModule } from './_utils' // Maybe we can import the list from somewhere, but idk const forceDevDependencies = [ - "@nuxt/eslint@latest", + "@nuxt/eslint", "@nuxtjs/color-mode" ] @@ -66,7 +66,7 @@ export default defineCommand({ // Add npm dependency if (!ctx.args.skipInstall) { - const isDev = Boolean(projectPkg.devDependencies?.nuxt || forceDevDependencies.includes(r.pkg)) + const isDev = Boolean(projectPkg.devDependencies?.nuxt || forceDevDependencies.includes(r.pkg.replace(/@latest$/,''))) consola.info( `Installing \`${r.pkg}\`${isDev ? ' development' : ''} dependency`, )