Skip to content

Conversation

@BobbieGoede
Copy link
Member

@BobbieGoede BobbieGoede commented Dec 6, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This changes the analyze command to change the chunk filenames to include the original human readable filename.

@manniL
In the issue you mention removing the hash entirely, if that's preferable I can change the PR. I figured including the hash could prevent duplicate filenames (not sure if possible) and in case these are used to invalidate build cache (I have no idea 🀷)

@BobbieGoede BobbieGoede self-assigned this Dec 6, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@e49583f). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/commands/analyze.ts 0.00% 10 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             main    #587   +/-   ##
======================================
  Coverage        ?   1.29%           
======================================
  Files           ?      44           
  Lines           ?    2864           
  Branches        ?      44           
======================================
  Hits            ?      37           
  Misses          ?    2785           
  Partials        ?      42           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@danielroe
Copy link
Member

I think the [name] would be fine on its own - rollup ensures it doesn't create duplicates.

@BobbieGoede
Copy link
Member Author

Nice, I removed the hash from the name pattern πŸš€

@danielroe danielroe merged commit 15d289a into nuxt:main Dec 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Analyze command should show descriptive file names

3 participants