From 8957945f76faedaf9980d3c3511ec6bf07f7a59e Mon Sep 17 00:00:00 2001 From: "Anthony Fu (via agent)" Date: Fri, 24 Jul 2026 12:49:10 +0000 Subject: [PATCH] fix(devtools): drop stale visibility assertion from nuxt-group e2e test feat(devtools)!: make embedded dock the only client mode (#1041) disabled the nuxt:devtools anchor's `visibility: 'false'` (its render-only hiding breaks the Nuxt group button's defaultChildId fallback) but left the e2e test asserting the old value, failing e2e on every push to main since. --- tests/e2e/specs/nuxt-group.spec.ts | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/tests/e2e/specs/nuxt-group.spec.ts b/tests/e2e/specs/nuxt-group.spec.ts index 6885d9ea8f..e03ac7ff26 100644 --- a/tests/e2e/specs/nuxt-group.spec.ts +++ b/tests/e2e/specs/nuxt-group.spec.ts @@ -54,17 +54,21 @@ test('registers a single `Nuxt` group with `nuxt:devtools` as its default child' expect(memberIds).toContain('nuxt:devtools:settings') expect(memberIds.length).toBeGreaterThan(1) - // The anchor's own dock button is redundant next to those members, so it's - // registered with a render-only `visibility: 'false'` (devframe#136): its - // button is suppressed while the entry stays registered — keeping its - // `subTabs`/`frameId` shared iframe alive and driving the nav loop. + // The anchor's own dock button would ideally be suppressed via a + // render-only `visibility: 'false'` (devframe#136) since it's redundant + // next to those members, but that's currently disabled in `module-main.ts` + // — the group button's `defaultChildId` fallback looks the entry up + // through the same visibility filter, so hiding the anchor also breaks + // clicking into it from the `Nuxt` group button. Once that's fixed + // upstream, re-enable `visibility: 'false'` there and restore this + // assertion. Until then, the entry stays registered and visible, keeping + // its `subTabs`/`frameId` shared iframe alive and driving the nav loop. const anchor = await page.evaluate(() => { const ctx = (globalThis as any).__VITE_DEVTOOLS_CLIENT_CONTEXT__ return ctx.docks.entries.find((entry: any) => entry.id === 'nuxt:devtools') }) expect(anchor).toMatchObject({ id: 'nuxt:devtools', - visibility: 'false', subTabs: { protocol: 'postmessage' }, }) })