From ad84c5eafe41b32b6313de276a9ac9118303d30e Mon Sep 17 00:00:00 2001
From: Anthony Fu <anthonyfu117@hotmail.com>
Date: Mon, 20 Nov 2023 17:50:51 +0100
Subject: [PATCH] feat: error tab

---
 .../client/components/StacktraceList.vue      | 42 ++++++++++
 .../components/TimelineDetailsFunction.vue    | 30 +------
 .../devtools/client/pages/modules/error.vue   | 78 +++++++++++++++++++
 .../src/runtime/plugins/devtools.client.ts    |  4 +-
 .../src/runtime/plugins/view/Main.vue         |  2 +
 .../tab-timeline/components/GlobalNav.vue     |  3 +
 playgrounds/tab-timeline/nuxt.config.ts       |  2 +-
 playgrounds/tab-timeline/pages/empty.vue      |  1 -
 playgrounds/tab-timeline/pages/error.vue      |  9 +++
 9 files changed, 141 insertions(+), 30 deletions(-)
 create mode 100644 packages/devtools/client/components/StacktraceList.vue
 create mode 100644 packages/devtools/client/pages/modules/error.vue
 create mode 100644 playgrounds/tab-timeline/pages/error.vue

diff --git a/packages/devtools/client/components/StacktraceList.vue b/packages/devtools/client/components/StacktraceList.vue
new file mode 100644
index 000000000..aff60dfdc
--- /dev/null
+++ b/packages/devtools/client/components/StacktraceList.vue
@@ -0,0 +1,42 @@
+<script setup lang="ts">
+import type { StackFrame } from 'error-stack-parser-es'
+
+defineProps<{
+  stacktrace: StackFrame[]
+}>()
+
+const config = useServerConfig()
+
+function urlToFilepath(url: string) {
+  try {
+    let pathname = new URL(url).pathname
+    if (pathname.startsWith('/_nuxt/'))
+      pathname = pathname.slice(6)
+    if (pathname.startsWith('/@id/virtual:nuxt:'))
+      return `#build/${pathname.split('/.nuxt/')[1]}`.replace(/\.m?js$/, '')
+    if (pathname.includes('/@fs/'))
+      return `/${pathname.split('/@fs/')[1]}`
+    return (config.value?.rootDir || '') + pathname
+  }
+  catch (e) {
+    return url
+  }
+}
+</script>
+
+<template>
+  <div mt2 grid="~ cols-[max-content_1fr] gap-x-4" font-mono>
+    <template v-for="item, idx of stacktrace" :key="idx">
+      <div text-right>
+        {{ item.functionName || `(anonymous)` }}
+      </div>
+      <div ws-nowrap>
+        <FilepathItem
+          v-if="item.fileName"
+          :filepath="`${urlToFilepath(item.fileName)}:${item.lineNumber}:${item.columnNumber}`"
+          subpath
+        />
+      </div>
+    </template>
+  </div>
+</template>
diff --git a/packages/devtools/client/components/TimelineDetailsFunction.vue b/packages/devtools/client/components/TimelineDetailsFunction.vue
index c1b11c8d5..d555395c6 100644
--- a/packages/devtools/client/components/TimelineDetailsFunction.vue
+++ b/packages/devtools/client/components/TimelineDetailsFunction.vue
@@ -5,20 +5,8 @@ const props = defineProps<{
   record: TimelineEventFunction
 }>()
 
-const config = useServerConfig()
 const timeAgo = useTimeAgo(() => props.record.start, { showSecond: true })
 
-function urlToFilepath(url: string) {
-  let pathname = new URL(url).pathname
-  if (pathname.startsWith('/_nuxt/'))
-    pathname = pathname.slice(6)
-  if (pathname.startsWith('/@id/virtual:nuxt:'))
-    return `#build/${pathname.split('/.nuxt/')[1]}`.replace(/\.m?js$/, '')
-  if (pathname.includes('/@fs/'))
-    return `/${pathname.split('/@fs/')[1]}`
-  return (config.value?.rootDir || '') + pathname
-}
-
 const autoImports = useAutoImports()
 const importsMetadata = computed(() => autoImports.value?.metadata)
 const importItem = computed(() => {
@@ -60,19 +48,9 @@ const importItem = computed(() => {
       </div>
     </div>
 
-    <div v-if="record.stacktrace" class="text-xs text-gray-400" mt2 grid="~ cols-[max-content_1fr] gap-x-4" font-mono>
-      <template v-for="item, idx of record.stacktrace" :key="idx">
-        <div text-right>
-          {{ item.functionName || `(anonymous)` }}
-        </div>
-        <div ws-nowrap>
-          <FilepathItem
-            v-if="item.fileName"
-            :filepath="`${urlToFilepath(item.fileName)}:${item.lineNumber}:${item.columnNumber}`"
-            subpath
-          />
-        </div>
-      </template>
-    </div>
+    <StacktraceList
+      v-if="record.stacktrace" :stacktrace="record.stacktrace"
+      class="text-xs text-gray-400"
+    />
   </div>
 </template>
diff --git a/packages/devtools/client/pages/modules/error.vue b/packages/devtools/client/pages/modules/error.vue
new file mode 100644
index 000000000..c3ee1c0c3
--- /dev/null
+++ b/packages/devtools/client/pages/modules/error.vue
@@ -0,0 +1,78 @@
+<script setup lang="ts">
+import { parse as parseStrackTrace } from 'error-stack-parser-es'
+
+definePageMeta({
+  icon: 'i-carbon-warning-alt-filled text-red',
+  title: 'Error',
+  category: 'app',
+  show() {
+    const client = useClient()
+    return () => client.value?.nuxt?.payload?.error
+  },
+})
+
+const client = useClient()
+const error = computed(() => {
+  const err = client.value?.nuxt?.payload?.error as {
+    url?: string
+    statusCode?: number
+    statusMessage?: string
+    message?: string
+    description?: string
+    data?: any
+  } & Error
+  if (err) {
+    console.error('[Nuxt DevTools] Error in payload:')
+    console.error(err)
+    console.error({ ...err })
+  }
+  return err
+})
+
+const stacks = computed(() => {
+  if (!error.value?.stack)
+    return []
+  try {
+    // Nuxt server returns a HTML rendered stacktrace, workaround by removing all HTML tags
+    if (error.value.stack.startsWith('<pre>')) {
+      return parseStrackTrace({
+        stack: error.value.stack.replace(/<.*?>/g, ''),
+      } as any)
+    }
+    return parseStrackTrace(error.value)
+  }
+  catch (e) {
+    console.error(e)
+    return []
+  }
+})
+</script>
+
+<template>
+  <div p6>
+    <div v-if="error">
+      <NTip n="red" icon="i-carbon-warning-alt-filled" mb5>
+        Error occurred in this page
+      </NTip>
+      <div text-6xl>
+        {{ error.statusCode || 'Client Error' }}
+      </div>
+      <div v-if="error.statusMessage" op75>
+        {{ error.statusMessage }}
+      </div>
+      <div my4 text-xl text-red>
+        {{ error.message || error.description || 'Unknown error' }}
+      </div>
+      <div v-if="stacks.length || error.stack" of-auto rounded bg-active p2>
+        <div px1 op50>
+          Stacktrace
+        </div>
+        <StacktraceList v-if="stacks.length" px2 :stacktrace="stacks" />
+        <pre v-else v-text="error.stack" />
+      </div>
+    </div>
+    <div v-else op50>
+      No error
+    </div>
+  </div>
+</template>
diff --git a/packages/devtools/src/runtime/plugins/devtools.client.ts b/packages/devtools/src/runtime/plugins/devtools.client.ts
index aefb83cec..c38b3b848 100644
--- a/packages/devtools/src/runtime/plugins/devtools.client.ts
+++ b/packages/devtools/src/runtime/plugins/devtools.client.ts
@@ -55,8 +55,8 @@ export default defineNuxtPlugin((nuxt: any) => {
   })
 
   import('./view/client')
-    .then(({ setupDevToolsClient }) => {
-      setupDevToolsClient({
+    .then(async ({ setupDevToolsClient }) => {
+      await setupDevToolsClient({
         nuxt,
         clientHooks,
         timeMetric,
diff --git a/packages/devtools/src/runtime/plugins/view/Main.vue b/packages/devtools/src/runtime/plugins/view/Main.vue
index 78d86ecce..c1c3be383 100644
--- a/packages/devtools/src/runtime/plugins/view/Main.vue
+++ b/packages/devtools/src/runtime/plugins/view/Main.vue
@@ -57,6 +57,8 @@ const draggingOffset = reactive({ x: 0, y: 0 })
 const mousePosition = reactive({ x: 0, y: 0 })
 
 function onPointerDown(e: PointerEvent) {
+  if (!panelEl.value)
+    return
   isDragging.value = true
   const { left, top, width, height } = panelEl.value!.getBoundingClientRect()
   draggingOffset.x = e.clientX - left - width / 2
diff --git a/playgrounds/tab-timeline/components/GlobalNav.vue b/playgrounds/tab-timeline/components/GlobalNav.vue
index 4c8dd5cdc..e40e8d8d9 100644
--- a/playgrounds/tab-timeline/components/GlobalNav.vue
+++ b/playgrounds/tab-timeline/components/GlobalNav.vue
@@ -23,6 +23,9 @@
       <NButton n="primary sm" to="/dynamic-bar" active-class="n-solid">
         /dynamic-bar
       </NButton>
+      <NButton n="primary sm" to="/error" active-class="n-solid">
+        /error
+      </NButton>
     </div>
   </div>
 </template>
diff --git a/playgrounds/tab-timeline/nuxt.config.ts b/playgrounds/tab-timeline/nuxt.config.ts
index 60a24a6f5..8583d0373 100644
--- a/playgrounds/tab-timeline/nuxt.config.ts
+++ b/playgrounds/tab-timeline/nuxt.config.ts
@@ -4,7 +4,7 @@ export default defineNuxtConfig({
     '../../packages/devtools-ui-kit/src/module',
     '../../local',
   ],
-  ssr: false,
+  ssr: true,
   vite: {
     clearScreen: false,
   },
diff --git a/playgrounds/tab-timeline/pages/empty.vue b/playgrounds/tab-timeline/pages/empty.vue
index 04e2cc2de..7b648447f 100644
--- a/playgrounds/tab-timeline/pages/empty.vue
+++ b/playgrounds/tab-timeline/pages/empty.vue
@@ -1,5 +1,4 @@
 <script setup lang="ts">
-
 </script>
 
 <template>
diff --git a/playgrounds/tab-timeline/pages/error.vue b/playgrounds/tab-timeline/pages/error.vue
new file mode 100644
index 000000000..a774c37f5
--- /dev/null
+++ b/playgrounds/tab-timeline/pages/error.vue
@@ -0,0 +1,9 @@
+<script setup lang="ts">
+throw new Error('This is an error thrown from error.vue')
+</script>
+
+<template>
+  <div>
+    Error
+  </div>
+</template>