Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please avoid changing basic StandardJS rules #25

Merged
merged 1 commit into from Feb 1, 2019

Conversation

Projects
None yet
6 participants
@kulikala
Copy link
Contributor

commented Feb 1, 2019

Hi, I'm a huge fan of Nuxt.js and recently I generated new Nuxt.js project with create-nuxt-app.

I found create-nuxt-app sets up ESLint with @nuxtjs/eslint-config and I think this is a great idea because everyone who starts to develop Nuxt.js application needs less laborious setting up processes.

That's why I strongly insist that changing basic StandardJS rules must be avoided.

Please customize your rules only with your terminatory project, not with commonly used library.

@manniL manniL requested review from nuxt/core-team, pi0, Atinux, galvez, clarkdo and kevinmarrec Feb 1, 2019

@pi0

pi0 approved these changes Feb 1, 2019

@clarkdo

This comment has been minimized.

Copy link
Contributor

commented Feb 1, 2019

The idea of this config should come frome @Atinux , let's wait his review.

And also it will require nuxt repos changes as well

@manniL

This comment has been minimized.

Copy link
Member

commented Feb 1, 2019

Hey @kulikala 👋

Thanks for your feedback!

I agree with this change (personally). It's been in there for a while

@manniL

This comment has been minimized.

Copy link
Member

commented Feb 1, 2019

Nevertheless, I think the best would be to have a dedicated config for all nuxt packages (internals and maybe modules as well) and a dedicated config that we suggest for the users.

@galvez

galvez approved these changes Feb 1, 2019

@galvez

This comment has been minimized.

Copy link
Member

commented Feb 1, 2019

+1

@Atinux Atinux merged commit 38e3582 into nuxt:master Feb 1, 2019

1 check passed

Travis CI - Pull Request Build Passed
Details
@Atinux

This comment has been minimized.

Copy link
Member

commented Feb 1, 2019

Thanks for the PR @kulikala

I do agree with this vision too 💚

@kulikala

This comment has been minimized.

Copy link
Contributor Author

commented Feb 3, 2019

Thanks @pi0, @clarkdo, @manniL, @galvez, and @Atinux for the quick response!

I'm waiting for this npm package to be updated with this fix, and I'll switch all my Nuxt projects to use @nuxtjs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.