From 4a1759be24bde7288aea46008f292dd228899d45 Mon Sep 17 00:00:00 2001 From: Pooya Parsa Date: Sat, 15 Oct 2022 12:51:15 +0200 Subject: [PATCH] update hookable --- packages/nuxt/package.json | 2 +- packages/nuxt/src/app/plugins/debug.ts | 5 +---- packages/nuxt/src/core/nuxt.ts | 12 ++++-------- yarn.lock | 9 ++++++++- 4 files changed, 14 insertions(+), 14 deletions(-) diff --git a/packages/nuxt/package.json b/packages/nuxt/package.json index b2daa818662..d706549f218 100644 --- a/packages/nuxt/package.json +++ b/packages/nuxt/package.json @@ -54,7 +54,7 @@ "globby": "^13.1.2", "h3": "^0.7.21", "hash-sum": "^2.0.0", - "hookable": "^5.4.0", + "hookable": "^5.4.1", "knitwork": "^0.1.2", "magic-string": "^0.26.7", "mlly": "^0.5.16", diff --git a/packages/nuxt/src/app/plugins/debug.ts b/packages/nuxt/src/app/plugins/debug.ts index b04702a5204..e0c67f2b863 100644 --- a/packages/nuxt/src/app/plugins/debug.ts +++ b/packages/nuxt/src/app/plugins/debug.ts @@ -2,8 +2,5 @@ import { createDebugger } from 'hookable' import { defineNuxtPlugin } from '#app' export default defineNuxtPlugin((nuxtApp) => { - // @ts-expect-error remove in next version of hookable - createDebugger(nuxtApp.hooks, { - tag: 'nuxt app' - }) + createDebugger(nuxtApp.hooks, { tag: 'nuxt-app' }) }) diff --git a/packages/nuxt/src/core/nuxt.ts b/packages/nuxt/src/core/nuxt.ts index 20bdabf2552..801311d62cc 100644 --- a/packages/nuxt/src/core/nuxt.ts +++ b/packages/nuxt/src/core/nuxt.ts @@ -1,5 +1,5 @@ import { join, normalize, resolve } from 'pathe' -import { createHooks } from 'hookable' +import { createHooks, createDebugger } from 'hookable' import type { Nuxt, NuxtOptions, NuxtConfig, ModuleContainer, NuxtHooks } from '@nuxt/schema' import { loadNuxtConfig, LoadNuxtOptions, nuxtCtx, installModule, addComponent, addVitePlugin, addWebpackPlugin, tryResolveModule, addPlugin } from '@nuxt/kit' // Temporary until finding better placement @@ -234,13 +234,9 @@ export async function loadNuxt (opts: LoadNuxtOptions): Promise { const nuxt = createNuxt(options) - // TODO: parallel kit:compatibility calls in defineModule - // if (nuxt.options.debug) { - // // @ts-expect-error remove in next version of hookable - // createDebugger(nuxt.hooks, { - // tag: 'nuxt build' - // }) - // } + if (nuxt.options.debug) { + createDebugger(nuxt.hooks, { tag: 'nuxt' }) + } if (opts.ready !== false) { await nuxt.ready() diff --git a/yarn.lock b/yarn.lock index c03e61cfdd9..f3e05a5f3f1 100644 --- a/yarn.lock +++ b/yarn.lock @@ -8380,6 +8380,13 @@ __metadata: languageName: node linkType: hard +"hookable@npm:^5.4.1": + version: 5.4.1 + resolution: "hookable@npm:5.4.1" + checksum: 2a48150436bf70b4b756bcf15694809032c490c1747aba363a6de928a96712e808b0918de06c933e082cc2042c3f051b593d400df6af4773cd9ad1e85d677839 + languageName: node + linkType: hard + "hosted-git-info@npm:^2.1.4": version: 2.8.9 resolution: "hosted-git-info@npm:2.8.9" @@ -11029,7 +11036,7 @@ __metadata: globby: ^13.1.2 h3: ^0.7.21 hash-sum: ^2.0.0 - hookable: ^5.4.0 + hookable: ^5.4.1 knitwork: ^0.1.2 magic-string: ^0.26.7 mlly: ^0.5.16