Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with IE 11 #126

Open
danielroe opened this issue Aug 28, 2020 — with CMTY · 11 comments
Open

Not compatible with IE 11 #126

danielroe opened this issue Aug 28, 2020 — with CMTY · 11 comments

Comments

Copy link
Member

danielroe commented Aug 28, 2020

Version

v0.5.11

Reproduction link

https://github.com/danielroe/nuxt-ie-http

See also browser support statement in ky README

Steps to reproduce

Although Nuxt polyfills unfetch in IE, ky uses an implementation of the header class that isn't compatible with IE 11.

Probably worth mentioning in the docs.

What is expected ?

IE11 support or a mention in the docs

What is actually happening?

No mention

@cmty cmty bot added the cmty:bug-report label Aug 28, 2020
@pi0
Copy link
Member

pi0 commented Aug 28, 2020

We do transpile ky (src). Can you please share some more info about error?

@danielroe
Copy link
Member Author

danielroe commented Aug 28, 2020

Sure. I'll prepare a reproduction. It's worth noting that the error only shows up in production - not in dev.

@danielroe
Copy link
Member Author

danielroe commented Aug 28, 2020

https://github.com/danielroe/nuxt-ie-http

Just build/start and view in IE.

Error screenshot:
Screenshot from 2020-08-28 11-51-51

@danielroe
Copy link
Member Author

danielroe commented Aug 28, 2020

I have written an almost-drop-in replacement for ky + this module that does work in IE. As I recall the issue was ky's implementation of the Headers class. I'm not suggesting changing @nuxt/http but it is worth noting in the docs.

@pi0
Copy link
Member

pi0 commented Aug 28, 2020

Using ky is a little bit disappointing indeed... We may replace in next major version. Would you mind opening docs PR for notice? Later-one can check IE issue on VM and possible fix

@jloewe
Copy link

jloewe commented Sep 1, 2020

Unfortunately this is a game breaker for me and I will have to switch back to axios now :/

@pi0 do you have a specific library in mind for the next mayor version?

@pi0
Copy link
Member

pi0 commented Sep 1, 2020

@jloewe Most likely building on top of native fetch or an in-house (nuxt-contrib) project for universally using.

@danielroe
Copy link
Member Author

danielroe commented Sep 3, 2020

@pi0 would you like a PR to refactor this module not to use ky?

@Atinux
Copy link
Member

Atinux commented Oct 16, 2020

I vote 👍 to remove ky here and only depend on fetch. I let @pi0 confirm, thank you for your help @danielroe 💚

@Atinux Atinux added the pending label Dec 22, 2020 — with Volta.net
@ricardogobbosouza
Copy link
Contributor

ricardogobbosouza commented Mar 1, 2021

Hi @Atinux, @pi0
Can I refactor this module to use https://github.com/nuxt-contrib/ohmyfetch ?

@pi0
Copy link
Member

pi0 commented Mar 1, 2021

#141 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants