feat: listen on new port #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 28, 2020 14:07
BREAKING CHANGE: no longer adding serverMiddleware
7 tasks
clarkdo
approved these changes
Apr 28, 2020
atinux
requested changes
Apr 28, 2020
added 2 commits
June 1, 2020 13:18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using WS before 1.x src but migrated to SSE because of two reasons:
But it started another issue (nuxt/nuxt#6442) as of connection limitations.
This PR resolves connection limit issue (so in the worst case, loading-indicator popup will not work until reload). After this PR we can add optional WS support as well because the server is separated so we don't get (2) issue and as is optional we won't get (1) issue.
As this is a breaking change for nuxt, we need to release as a major with some changes to nuxt for usage. (nuxt/nuxt#7286)