Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(csr): error page layout not correctly applied #2537

Closed
ac88 opened this issue Jan 9, 2018 · 23 comments · Fixed by #6479
Assignees

Comments

@ac88
Copy link

@ac88 ac88 commented Jan 9, 2018

//layouts\error.vue
{
layout: 'empty'
}

route to a 404 page.the error page layout is right

error1

but a page component has code error.

error2

when route to this page.

the error page layout is layouts\default.vue not layouts\error.vue


at nuxt@v1.0.0-rc11 not this problem.

This question is available on Nuxt.js community (#c2205)
@unr

This comment has been minimized.

Copy link

@unr unr commented Jan 9, 2018

I'm having this same issue since upgrading to 1.0

--

As a temporary fix, I've created an empty layout...

// in layouts/error.vue
layout: 'empty',

and in layouts/empty.vue

<template><nuxt /></template>

<script>
export default { name: 'EmptyLayout' };
</script>
@joealden

This comment has been minimized.

Copy link

@joealden joealden commented Jan 9, 2018

I am having the same issue.

I have two layouts in my layout directory, default.vue and error.vue.
The default layout is named default-layout and the error layout is named nuxt-error

When an error occurs, nuxt is rendering the error layout inside of the default layout as seen here:

Screenshot

@cesasol

This comment has been minimized.

Copy link

@cesasol cesasol commented Jan 10, 2018

Is an undocumented change, the error layout is no longer a layout and it works like a page

@joealden

This comment has been minimized.

Copy link

@joealden joealden commented Jan 10, 2018

@cesasol Oh really? Could you point me to the PR that was merged of this change please?

If you are right, it would have been nice to have that in the release notes, as I would consider it a breaking change!

@cesasol

This comment has been minimized.

Copy link

@cesasol cesasol commented Jan 10, 2018

I don't know, I upgraded, noted this and updated my code accordingly, yes it should be on the release notes but maybe not as a breaking change.

@rancongjie

This comment has been minimized.

Copy link

@rancongjie rancongjie commented Jan 10, 2018

@joealden

This comment has been minimized.

Copy link

@joealden joealden commented Jan 10, 2018

@cesasol I did the same, and it all works fine, but it's not the best way to experience a change. I've had a quick look through merged PRs and none stood out to me that were linked to this, which still makes me doubt whether this is an intentional change or a regression.

Also, I would myself consider this breaking, as it broke my error page.

If someone can give me evidence that this is an intentional change, I'll be more than happy to make a PR updating the docs with this.

@husayt

This comment has been minimized.

Copy link
Collaborator

@husayt husayt commented Mar 8, 2018

This seems to be resolved now. Closing. Reopen if still happens.

@husayt husayt closed this Mar 8, 2018
@ac88

This comment has been minimized.

Copy link
Author

@ac88 ac88 commented Mar 29, 2018

@husayt it sitll happens at nuxt 1.4.0

@Kimel1

This comment has been minimized.

Copy link

@Kimel1 Kimel1 commented Mar 31, 2018

Still have this issue

@husayt husayt reopened this Mar 31, 2018
@moltar

This comment has been minimized.

Copy link

@moltar moltar commented Apr 30, 2018

Get the same error.

If refreshing the URL with 404, the correct layout is applied.

If visiting the URL via a broken link within the same state, then the layout remains from the previous page (e.g. with nav and all).

@sinsong

This comment has been minimized.

Copy link

@sinsong sinsong commented Jun 29, 2018

I think we need a function that don't use any layout.

@galvez galvez self-assigned this Aug 18, 2018
@galvez galvez added the bug label Aug 18, 2018
@manniL manniL changed the title error page layout conflict bug(csr): error page layout not correctly applied Oct 18, 2018
@stale

This comment has been minimized.

Copy link

@stale stale bot commented Nov 10, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Nov 10, 2018
@manniL manniL removed the stale label Nov 12, 2018
@stale

This comment has been minimized.

Copy link

@stale stale bot commented Dec 3, 2018

Thanks for your contribution to Nuxt.js!
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you would like this issue to remain open:

  1. Verify that you can still reproduce the issue in the latest version of nuxt-edge
  2. Comment the steps to reproduce it

Issues that are labeled as 🕐Pending will not be automatically marked as stale.

@stale stale bot added the stale label Dec 3, 2018
@luisfavila

This comment has been minimized.

Copy link

@luisfavila luisfavila commented Dec 5, 2018

If refreshing the URL with 404, the correct layout is applied.
If visiting the URL via a broken link within the same state, then the layout remains from the previous page (e.g. with nav and all).

I'm using nuxt-edge 2.4.0 and this still happens.
@moltar have you found any solution?

@stale stale bot removed the stale label Dec 5, 2018
@stale

This comment has been minimized.

Copy link

@stale stale bot commented Dec 26, 2018

Thanks for your contribution to Nuxt.js!
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you would like this issue to remain open:

  1. Verify that you can still reproduce the issue in the latest version of nuxt-edge
  2. Comment the steps to reproduce it

Issues that are labeled as 🕐Pending will not be automatically marked as stale.

@stale stale bot added the stale label Dec 26, 2018
@stale stale bot closed this Jan 2, 2019
@saeed-darestany

This comment has been minimized.

Copy link

@saeed-darestany saeed-darestany commented May 5, 2019

#5654 🐛

@manniL manniL reopened this May 8, 2019
@stale stale bot removed the stale label May 8, 2019
@stale stale bot removed the stale label May 8, 2019
@saeed-darestany

This comment has been minimized.

Copy link

@saeed-darestany saeed-darestany commented Jun 1, 2019

@Atinux @pi0
any news on this ?

@Leskd

This comment has been minimized.

Copy link

@Leskd Leskd commented Jul 4, 2019

any news on this ?

@louisluu

This comment has been minimized.

Copy link

@louisluu louisluu commented Sep 15, 2019

Encountered this issue in Nuxt 2.8.1

Any update?

@JulienAramino

This comment has been minimized.

Copy link

@JulienAramino JulienAramino commented Sep 16, 2019

Same on 2.9.2
The page 200.html is not generate properly

@KleinMaximus

This comment has been minimized.

Copy link

@KleinMaximus KleinMaximus commented Sep 17, 2019

Same on 2.9.2

@manniL

This comment has been minimized.

Copy link
Member

@manniL manniL commented Sep 28, 2019

@clarkdo I've reassigned you here and closed #5654 as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.