Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: match subdir under node_module in transpile #4850

Merged
merged 1 commit into from Jan 24, 2019

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Jan 24, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo requested review from pi0 and Atinux January 24, 2019 15:07
@@ -225,8 +225,10 @@ export default class WebpackBaseConfig {
{
test: /\.jsx?$/i,
exclude: (file) => {
file = file.split('node_modules', 2)[1]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if node_modules is not included in that path? 🤔

(Is that even possible?)

Copy link
Member Author

@clarkdo clarkdo Jan 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it doesn't include node_modules, then it won't be included in loader, same as before

They are same:

!!file.split('node_modules', 2)[1]

/node_modules/.test(file)

@codecov-io
Copy link

Codecov Report

Merging #4850 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4850      +/-   ##
==========================================
+ Coverage   91.27%   91.27%   +<.01%     
==========================================
  Files          73       73              
  Lines        2360     2361       +1     
  Branches      582      582              
==========================================
+ Hits         2154     2155       +1     
  Misses        188      188              
  Partials       18       18
Impacted Files Coverage Δ
packages/webpack/src/config/base.js 95.4% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a51ba8d...11f4ff5. Read the comment docs.

@Atinux Atinux merged commit 43ce8e9 into nuxt:dev Jan 24, 2019
@Haroenv
Copy link

Haroenv commented Jan 24, 2019

Thanks @clarkdo, @manniL and of course also @Atinux for finding this! I was staring at the wrong things altogether :)

@clarkdo
Copy link
Member Author

clarkdo commented Jan 24, 2019

@Haroenv You're welcome, thank you so much for your interest in Nuxt.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants