New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: match subdir under node_module in transpile #4850
Conversation
@@ -225,8 +225,10 @@ export default class WebpackBaseConfig { | |||
{ | |||
test: /\.jsx?$/i, | |||
exclude: (file) => { | |||
file = file.split('node_modules', 2)[1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if node_modules
is not included in that path? 🤔
(Is that even possible?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it doesn't include node_modules
, then it won't be included in loader, same as before
They are same:
!!file.split('node_modules', 2)[1]
/node_modules/.test(file)
Codecov Report
@@ Coverage Diff @@
## dev #4850 +/- ##
==========================================
+ Coverage 91.27% 91.27% +<.01%
==========================================
Files 73 73
Lines 2360 2361 +1
Branches 582 582
==========================================
+ Hits 2154 2155 +1
Misses 188 188
Partials 18 18
Continue to review full report at Codecov.
|
@Haroenv You're welcome, thank you so much for your interest in Nuxt.js |
Types of changes
Description
Checklist: