Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(postcss): deprecate config support #5419

Merged
merged 6 commits into from Mar 30, 2019
Merged

Conversation

manniL
Copy link
Member

@manniL manniL commented Mar 29, 2019

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Feature deprecation

Description

Using a postcss.config.js or a similar file will not apply any of the default plugins coming with Nuxt which could lead to severe issues (like not resolving aliases).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@manniL manniL requested review from a team and clarkdo March 29, 2019 23:49
@codecov-io
Copy link

codecov-io commented Mar 30, 2019

Codecov Report

Merging #5419 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #5419      +/-   ##
==========================================
+ Coverage   96.18%   96.19%   +<.01%     
==========================================
  Files          74       74              
  Lines        2544     2549       +5     
  Branches      648      649       +1     
==========================================
+ Hits         2447     2452       +5     
  Misses         81       81              
  Partials       16       16
Impacted Files Coverage Δ
packages/webpack/src/utils/postcss.js 93.22% <100%> (+0.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 832bd12...f6c19b3. Read the comment docs.

@manniL manniL requested a review from pi0 March 30, 2019 14:18
pi0
pi0 previously approved these changes Mar 30, 2019
@pi0 pi0 merged commit 1bd4fb1 into dev Mar 30, 2019
@pi0 pi0 deleted the chore-deprecate-postcss-config branch March 30, 2019 19:12
@pi0 pi0 mentioned this pull request Mar 31, 2019
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants