Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting to disable console.logs per generated page #5510

Closed
Frankwarnaar opened this issue Apr 11, 2019 — with CMTY · 6 comments

Comments

Copy link

commented Apr 11, 2019 — with CMTY

What problem does this feature solve?

  • When generating thousands of pages the build log becomes enormous.
  • I'm using Netlify for hosting my static website. They're streaming their build logs to their UI and have a build time limit of 30 minutes. When generating thousands of pages, a delay starts to exist between the log output and the log preview in their UI, causing the build to exceed the build time limit.

What does the proposed changes look like?

Add an option to the generate options to make logging a line per generated page conditional. Just log something like Generated 9000 pages.

This feature request is available on Nuxt community (#c9030)
@seifsay3d

This comment has been minimized.

Copy link

commented Jun 27, 2019

Is someone working on this? if not I would like to give it a shot.

@pi0

This comment has been minimized.

Copy link
Member

commented Jun 27, 2019

@seifsay3d It is on progress on #5517

@Frankwarnaar

This comment has been minimized.

Copy link
Author

commented Jun 28, 2019

I still have to write documentation and some tests, but don't really have time to do so. So please, feel free to give it a go! I already have a PR open.

@seifsay3d

This comment has been minimized.

Copy link

commented Jun 28, 2019

Alright cool, I'm pretty new to OSS, should I just fork your fork ? add tests and docs and to PR against official nuxt?

@Frankwarnaar

This comment has been minimized.

Copy link
Author

commented Jun 28, 2019

Yes, I think that's the easiest way to go. I have to say: I'm pretty new to snapshot testing, so I'm not sure my changes I did in the tests are wanted.

@pi0

This comment has been minimized.

Copy link
Member

commented Jun 28, 2019

Please hold on. As of thread in related PR we may use log levels for disable per-route logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.