New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(builder): watch store dir and serverMiddleware
paths
#5681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atinux
commented
May 9, 2019
Codecov Report
@@ Coverage Diff @@
## dev #5681 +/- ##
==========================================
+ Coverage 95.57% 95.59% +0.01%
==========================================
Files 81 81
Lines 2645 2656 +11
Branches 673 679 +6
==========================================
+ Hits 2528 2539 +11
Misses 98 98
Partials 19 19
Continue to review full report at Codecov.
|
pi0
reviewed
May 10, 2019
pi0
changed the title
fix(builder): Watch store dir (when false) and serverMiddleware paths
fix(builder): watch store dir and May 10, 2019
serverMiddleware
paths
Merged
pi0
approved these changes
May 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Problems
Right now, when we use
serverMiddleware
and change them (the files linked tooptions.serverMiddleware
), a restart happen but the file is cached, leading to a useless restart.The other problem is when we start a nuxt app without a
store/
directory, and while runningnuxt dev
, when we add the directory with a file in it (store/index.js
), Nuxt does nothing and we have to manually restart the project (really annoying).Solution
Watch paths of
serverMiddleware
+ clear cache of the fileWatch
store/
directory for full reload whenthis.options.store === false
Checklist: