Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(generator): ensure manifest dir exists #8474

Merged
merged 1 commit into from Dec 11, 2020
Merged

fix(generator): ensure manifest dir exists #8474

merged 1 commit into from Dec 11, 2020

Conversation

Atinux
Copy link
Member

@Atinux Atinux commented Dec 11, 2020

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

When no route can be generated in full static, we don't ensure the staticDir to exists, this PR fixes it.

Screenshot 2020-12-11 at 13 30 29

Checklist:

  • All new and existing tests are passing.

@pi0 pi0 changed the title fix(generator): ensure manifest dir fix(generator): ensure manifest dir exists Dec 11, 2020
@pi0 pi0 merged commit dd7f767 into dev Dec 11, 2020
@pi0 pi0 deleted the fix/ensure-manifest branch December 11, 2020 12:34
@pi0 pi0 mentioned this pull request Jan 4, 2021
Merged
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Atinux @pi0 @danielroe