feature: add static.prefix

[clarkdo]

Resolve #2753

Add render.static.prefix to check if need to append router.base to serveStatic

[codecov-io]

Codecov Report

Merging #2755 into dev will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              dev    #2755      +/-   ##
==========================================
+ Coverage   99.91%   99.91%   +<.01%     
==========================================
  Files          23       23              
  Lines        1211     1213       +2     
==========================================
+ Hits         1210     1212       +2     
  Misses          1        1

Impacted Files	Coverage Δ
lib/common/options.js	100% <ø> (ø)	⬆️
lib/core/renderer.js	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2158327...e60a8e7. Read the comment docs.

[Atinux]

Dont we need a default value?

[clarkdo]

@Atinux

useMiddleware only accepts prefix !== false https://github.com/nuxt/nuxt.js/blob/dev/lib/core/renderer.js#L193, so unless manually config static.prefix: false, it will have the prefix anyway.

[pi0]

Code readability suggestion: Boolean(this.options.render.static.prefix).

[clarkdo]

It may make unexpected behavior, if not config static.prefix, it will be false and ignore the prefix, but prefix should not be ignored by default.

[pi0]

So what if we add a default value true in https://github.com/nuxt/nuxt.js/blob/215832769edc42e7077e8db970fbcda3276ecf0a/lib/common/options.js#L308? This prefix is little confusing now. Because it doesn't means use this prefix string but means just use prefix 😆

[clarkdo]

@pi0 Added the default value.

[clarkdo]

Sure，I will make a change tmr morning ：） Pooya Parsa <notifications@github.com>于2018年2月4日 周日23:28写道：

***@***.**** commented on this pull request. ------------------------------ In lib/core/renderer.js <#2755 (comment)>: > ) + staticMiddleware.prefix = this.options.render.static.prefix So what if we add a default value true in https://github.com/nuxt/nuxt.js/blob/215832769edc42e7077e8db970fbcda3276ecf0a/lib/common/options.js#L308? This prefix is little confusing now. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2755 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEHMWtRKj_PjjeGqu31UzbgKNkhIIEQyks5tRcyigaJpZM4R4PKC> .

-- Regards, Clark

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.