Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `loading: false` option to pages #3629

Merged
merged 28 commits into from Aug 5, 2018

Conversation

@galvez
Copy link
Member

commented Aug 3, 2018

@Atinux finally got it to work, the example app should illustrate usage properly.

Feel free to edit if you think there's a better approach!

@codecov-io

This comment has been minimized.

Copy link

commented Aug 3, 2018

Codecov Report

Merging #3629 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #3629   +/-   ##
=======================================
  Coverage   99.19%   99.19%           
=======================================
  Files          18       18           
  Lines        1122     1122           
  Branches      302      302           
=======================================
  Hits         1113     1113           
  Misses          9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbba872...5c4bf37. Read the comment docs.

galvez added some commits Aug 3, 2018

@manniL

This comment has been minimized.

Copy link
Member

commented Aug 4, 2018

Could you add tests for the new feature? :)

@galvez

This comment has been minimized.

Copy link
Member Author

commented Aug 4, 2018

@manniL yep! Working on it.

@galvez

This comment has been minimized.

Copy link
Member Author

commented Aug 4, 2018

Ok, test is passing currently being debugged :)

galvez added some commits Aug 4, 2018

galvez added some commits Aug 4, 2018

@galvez

This comment has been minimized.

Copy link
Member Author

commented Aug 4, 2018

@Atinux @manniL tests are passing!

@galvez

This comment has been minimized.

Copy link
Member Author

commented Aug 4, 2018

Created a PR in nuxt/docs as well.

@Atinux Atinux merged commit 0e42e98 into nuxt:dev Aug 5, 2018

7 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
security/snyk - package.json (Atinux) No manifest changes detected
Show resolved Hide resolved lib/app/client.js
@lock

This comment has been minimized.

Copy link

commented Oct 31, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 31, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.