Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Overwrite store.registerModule #3909

Merged
merged 3 commits into from Sep 18, 2018
Merged

feat: Overwrite store.registerModule #3909

merged 3 commits into from Sep 18, 2018

Conversation

Atinux
Copy link
Member

@Atinux Atinux commented Sep 18, 2018 •
edited

Make store.registerModule works seamlessly with server-side rendering.

Related to #3757 (comment)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests passed.

@Atinux
feat: Overwrite store.registerModule
2966a73 
Make `store.registerModule` works seamlessly with server-side rendering.
@Atinux Atinux requested a review from clarkdo September 18, 2018 14:22
clarkdo
clarkdo approved these changes Sep 18, 2018
View reviewed changes
Copy link
Member

@clarkdo clarkdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Atinux Atinux merged commit 6975655 into dev Sep 18, 2018
@Atinux Atinux deleted the feat-store-module branch September 18, 2018 15:21
@Atinux Atinux mentioned this pull request Sep 18, 2018
Closed
@lock
Copy link

lock bot commented Oct 31, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 31, 2018
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clarkdo clarkdo clarkdo approved these changes

Assignees
No one assigned
Labels
2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Atinux @clarkdo @danielroe