New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): support async nuxt.config.js #4021

Merged
merged 2 commits into from Oct 18, 2018

Conversation

Projects
None yet
5 participants
@manniL
Member

manniL commented Sep 30, 2018

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

With this PR, the nuxt.config.js export can be async now and will be awaited properly.
Resolves #4005

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #TODO)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@manniL manniL added the WIP label Sep 30, 2018

@manniL manniL requested review from galvez, Atinux, clarkdo and pi0 Sep 30, 2018

@manniL manniL removed the WIP label Sep 30, 2018

@manniL

This comment has been minimized.

Member

manniL commented Sep 30, 2018

This seemed a little bit too easy though 🤔

@manniL manniL self-assigned this Sep 30, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Sep 30, 2018

Codecov Report

Merging #4021 into dev will decrease coverage by 0.47%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4021      +/-   ##
==========================================
- Coverage   82.25%   81.78%   -0.48%     
==========================================
  Files          29       29              
  Lines        1550     1559       +9     
  Branches      408      409       +1     
==========================================
  Hits         1275     1275              
- Misses        216      224       +8     
- Partials       59       60       +1
Impacted Files Coverage Δ
packages/cli/src/commands/start.js 0% <0%> (ø) ⬆️
packages/cli/src/commands/generate.js 0% <0%> (ø) ⬆️
packages/cli/src/commands/build.js 0% <0%> (ø) ⬆️
packages/cli/src/commands/dev.js 0% <0%> (ø) ⬆️
packages/cli/src/common/utils.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab5af54...c6bc8a9. Read the comment docs.

Show resolved Hide resolved bin/nuxt-build Outdated
Show resolved Hide resolved bin/common/utils.js Outdated
exports.runAsyncScript = (fn) => {
fn().then(() => { process.exit(0) })
.catch((err) => {
consola.fatal('Failed to run async Buxt script!')

This comment has been minimized.

@pi0

pi0 Sep 30, 2018

Member

Typo + Script is not always build :)

Show resolved Hide resolved bin/common/utils.js Outdated
@manniL

This comment has been minimized.

Member

manniL commented Sep 30, 2018

had to remove the process.exit(0) because of the console statements afterwards (Compiled successfully for example)

@pi0

Except for yarn.lock, LGTM 👍

@manniL manniL force-pushed the feat-async-config branch 2 times, most recently from dd45697 to 5ad7420 Oct 1, 2018

@galvez

This comment has been minimized.

Member

galvez commented Oct 7, 2018

@manniL Fixed conflicts, tests seem ok!

@manniL manniL force-pushed the feat-async-config branch 4 times, most recently from 0397e2f to 99b34c6 Oct 9, 2018

@manniL

This comment has been minimized.

Member

manniL commented Oct 11, 2018

Tests fixed! cc @pi0 @clarkdo

@manniL manniL referenced this pull request Oct 11, 2018

Merged

fix: style module with extractCSS not work well #4093

1 of 7 tasks complete

@manniL manniL force-pushed the feat-async-config branch from d087358 to 4761ee4 Oct 18, 2018

@manniL

This comment has been minimized.

Member

manniL commented Oct 18, 2018

@pi0 Updated to latest dev ☺️

@manniL manniL dismissed stale reviews from pi0 and galvez Oct 18, 2018

new dev

@pi0

pi0 approved these changes Oct 18, 2018

@pi0 pi0 changed the title from feat: allow async nuxt.config.js to feat(cli): support async nuxt.config.js Oct 18, 2018

@pi0 pi0 merged commit f27939d into dev Oct 18, 2018

8 checks passed

ci/circleci: audit Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
security/snyk - package.json (Atinux) No manifest changes detected

@pi0 pi0 deleted the feat-async-config branch Oct 18, 2018

@lock

This comment has been minimized.

lock bot commented Nov 17, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.