New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modern build #4231

Merged
merged 13 commits into from Oct 31, 2018

Conversation

Projects
None yet
4 participants
@clarkdo
Member

clarkdo commented Oct 30, 2018

Types of changes

  • New feature (a non-breaking change which adds functionality)

Description

  • SPA modern build
  • SSR modern rendering
  • CLI command
  • Test
  • Documentation
  • Release Note

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: #)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

@clarkdo clarkdo added the WIP label Oct 30, 2018

@clarkdo clarkdo force-pushed the feat/modern branch from 0f2168e to 32d59ae Oct 30, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Oct 30, 2018

Codecov Report

Merging #4231 into dev will increase coverage by 0.02%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4231      +/-   ##
==========================================
+ Coverage   94.01%   94.04%   +0.02%     
==========================================
  Files          49       50       +1     
  Lines        1653     1678      +25     
  Branches      425      436      +11     
==========================================
+ Hits         1554     1578      +24     
- Misses         96       97       +1     
  Partials        3        3
Impacted Files Coverage Δ
packages/webpack/src/config/client.js 97.36% <100%> (+0.14%) ⬆️
packages/webpack/src/config/base.js 98.46% <100%> (+0.04%) ⬆️
packages/config/src/config/build.js 85.71% <100%> (ø) ⬆️
packages/webpack/src/config/modern.js 100% <100%> (ø)
packages/vue-renderer/src/renderer.js 100% <100%> (ø) ⬆️
packages/cli/src/commands/build.js 77.27% <66.66%> (-1.68%) ⬇️
packages/webpack/src/builder.js 97.29% <80%> (-1.26%) ⬇️
packages/babel-preset-app/src/index.js 100% <0%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c86dfbf...c4a9d05. Read the comment docs.

@clarkdo clarkdo closed this Oct 30, 2018

@clarkdo clarkdo force-pushed the feat/modern branch from fc972e4 to 39b558f Oct 30, 2018

@clarkdo clarkdo reopened this Oct 30, 2018

clarkdo added some commits Oct 30, 2018

@manniL manniL referenced this pull request Oct 31, 2018

Closed

feat: modern mode build #3848

6 of 13 tasks complete

clarkdo added some commits Oct 31, 2018

@clarkdo clarkdo requested a review from pi0 Oct 31, 2018

@clarkdo clarkdo removed the WIP label Oct 31, 2018

@pi0

pi0 approved these changes Oct 31, 2018

@clarkdo clarkdo merged commit bed0714 into dev Oct 31, 2018

8 checks passed

[ci.azure] nuxt.js #20181031.18 succeeded
Details
ci/circleci: audit Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details
security/snyk - package.json (Atinux) No manifest changes detected

@Atinux Atinux deleted the feat/modern branch Nov 2, 2018

@manniL manniL referenced this pull request Nov 10, 2018

Closed

Document modern mode #967

@lock

This comment has been minimized.

lock bot commented Dec 2, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 2, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.