New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add `--devtools` option for build and generate #4357

Merged
merged 7 commits into from Nov 17, 2018

Conversation

Projects
None yet
6 participants
@mottox2
Contributor

mottox2 commented Nov 17, 2018

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

This PR aimed to resolve issue #4117.

This PR adds devtools option to nuxt-generate.
Whee devtools option is enabled, devtool is enabled and debugging is easy.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly. (PR: nuxt/docs#991)
  • I have added tests to cover my changes (if not applicable, please state why)
  • All new and existing tests are passing.

mottox2 added some commits Nov 17, 2018

@codecov-io

This comment has been minimized.

codecov-io commented Nov 17, 2018

Codecov Report

Merging #4357 into dev will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #4357      +/-   ##
==========================================
+ Coverage   91.47%   91.51%   +0.03%     
==========================================
  Files          56       56              
  Lines        1877     1885       +8     
  Branches      469      475       +6     
==========================================
+ Hits         1717     1725       +8     
  Misses        150      150              
  Partials       10       10
Impacted Files Coverage Δ
packages/cli/src/commands/generate.js 76.92% <100%> (+10.25%) ⬆️
packages/cli/src/commands/build.js 81.81% <100%> (+4.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5716eb...98eb17b. Read the comment docs.

@pi0

This comment has been minimized.

Member

pi0 commented Nov 17, 2018

@mottox2 This option would be useful for nuxt build too :D

@mottox2 mottox2 changed the title from feat(cli): Add development option to generate to feat(cli): Add devtools option to generate Nov 17, 2018

@pi0 pi0 changed the title from feat(cli): Add devtools option to generate to feat(cli): add `--devtools` option to `nuxt generate` Nov 17, 2018

@mottox2

This comment has been minimized.

Contributor

mottox2 commented Nov 17, 2018

@pi0
Thanks you for reviewing. I renamed it.

This option would be useful for nuxt build too :D

I would like to do this change. Should I change this in this PR or another PR?

@pi0

This comment has been minimized.

Member

pi0 commented Nov 17, 2018

@mottox2 thanks for rename. Your choice if want to continue works on this PR. The refactor includes creating a file in cli/src/options/build.js, move added option there and import build in both generate and build. BTW no pressure if you want we can merge this as-as :)

@pi0 pi0 requested a review from manniL Nov 17, 2018

@pi0

Duplicate logic can be refactored. But safe to delegate this refactoring to later :)

@pi0 pi0 changed the title from feat(cli): add `--devtools` option to `nuxt generate` to feat(cli): add `--devtools` option for build and generate Nov 17, 2018

@clarkdo clarkdo self-requested a review Nov 17, 2018

@manniL manniL dismissed stale reviews from clarkdo and pi0 via db4e3e5 Nov 17, 2018

@manniL

This comment has been minimized.

Member

manniL commented Nov 17, 2018

Slightly improved the cmd descriptions

@manniL

manniL approved these changes Nov 17, 2018

@pi0

pi0 approved these changes Nov 17, 2018

@clarkdo clarkdo merged commit e6f73b5 into nuxt:dev Nov 17, 2018

9 checks passed

Semantic Pull Request ready to be squashed
Details
[ci.azure] nuxt.js #20181117.13 succeeded
Details
ci/circleci: audit Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test-e2e Your tests passed on CircleCI!
Details
ci/circleci: test-unit Your tests passed on CircleCI!
Details
security/snyk - package.json (Atinux) No manifest changes detected
@clarkdo

This comment has been minimized.

Member

clarkdo commented Nov 17, 2018

@mottox2 Thanks 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment